[Cainehill]

Originally posted by alexti:

quote:

---

Originally posted by Cainehill:
Hard to say how to rewrite the expression without seeing the source code and expression

Johan has posted the code that was causing problems. It was like that:

code:

---

  if (n + d6() < m + d6())

---

and different compilers evaluated left and right subexpressions in a different order.

---

Ah - Graeme is right, parenthesis's wouldn't do it, but it wouldn't be 100% necessary to use discrete lines of code either:

code:

---

  if ((int left = n + d6()) && (int right = m + d6()) && (left < right))

---

Still not pretty, but each '&&' introduces a sequence point, and the short-circuit boolean rules means that the ones to the right are only executed if the previous one was true. Presuming that d6() returns a value between 1 and 6 (and that n and m are unsigned or otherwise always non-negative values), the first two are true, and the final, real, test is whether left is less than right.

Somewhat ugly, but not as counter-intuitive as using non-stochastic dice rolls.

[ March 27, 2004, 13:54: Message edited by: Cainehill ]