New patch??

[lch]

Edi said:
I really need to get cracking on the typos...

When you have the typos "fixed", would you open the patch up for peer review before it is applied? Then some other people have a chance to find things which you may have overlooked.

[Tyrant]

I'd nominate EA Ulm and second LA Aby for nations in need of work.

[Edi]

lch said:

When you have the typos "fixed", would you open the patch up for peer review before it is applied? Then some other people have a chance to find things which you may have overlooked.

The only part of the code I've seen are the description files and you need to ask Kristoffer that. You can take my word for it that I did spend over a month going over a string dump and fixing everything I found and Kristoffer gave me the actual source files to work with because most of the work was already done. I've caught a couple of very minor stylistic things from the nation descriptions which I'm redoing and a couple of other changes I went over with Kristoffer, but other than that it's going to be a straight find and replace.

I cannot give you the source files, but I can give you the strings extracted from the dump and accompanied by the fixed versions so you can look them over yourself. I'll be doublechecking everything as I fix it, so you will have a very hard time finding anything. If you do, let me know, but there are thousands of typo fixes there, from misspellings to grammar to punctuation, so much more than what was reported in the in-game typo thread. Enjoy yourself.

I will warn you that not QUITE everything will be fixed by what I do, since not all of the strings (such as event descriptions, including global enchantment texts or name lists) are in the description files and those will be left up to KO and JK.

Fixed strings attached.

[lch]

Edi said:
I cannot give you the source files, but I can give you the strings extracted from the dump and accompanied by the fixed versions so you can look them over yourself.

That's exactly what I wanted. Having the original *.txt file and a patch (you know the *nix command "patch"?) would have been better maybe, but this is still very good. Please commit your final version when you have compiled it again.

[lch]

Edi, after a quick look it seems you really did extensive fixing. A few things that caught my eye:

- You sometimes use lower case for units, like "The asp turtle" at the very beginning, or "iron ancestor" for "Iron Ancestor" while at the same time you use "Tomb Oracles" and "Seal Guards" at the next occasion. How come?

- I think that it should be "appetite" instead of "appetites" in most cases, but then again I'm not a native English speaker. (see, I even have to capitalize that word... )

[Edi]

Normal English capitalization rules. Everything is lower case unless the monster name is

• Rank (e.g. Centurion, Legatus Legionis, Lord Guardian)
• member of a military or other order (e.g. Wind Rider, Seal Guard, Guardian (of Ulm) as opposed to e.g. heavy infantry or infantry of Ulm)
• unique monster (e.g. Eater of Gods, King of Banefires)
• commander is not capitalized because that is too much of a generic descriptive rather than rank

As I said, everything will get reviewed when I work with the description files, but I did pay a lot of attention to this issue.

Spell descriptions (not in that text file) will have the names of all monsters they summon capitalized for clarity.

The selection of appetite/appetites depends on the context, but both of those are normal English. I'd elaborate, but I have early morning shift tomorrow and I need to hit the sack.

[MaxWilson]

Wow, I'm impressed. My eyes are bleeding from all that text. I didn't spot any issues with the corrected text, though. Nice work!

-Max

[Beorne]

Among all the bug everyone tries to push on the face of KO I'd like to highlight the (already highlighted) red bugs, in particular the fort issues (that should be very easy to correct) and the Dominion (spread, scales) issues, that can ruin a game. I kno these are JK things.
It's not fair that a game named Dominion has some big Dominion bugs.

[Gandalf Parker]

lch said:

When you have the typos "fixed", would you open the patch up for peer review before it is applied? Then some other people have a chance to find things which you may have overlooked.

You mean just the typo fix list?
The patch gets a peer review by the beta group prior to release