Help my ships won't attack

[Suicide Junkie]

we are closing with them and remaining in the same space but no combat happens.

Since you can't get into the same combat square without ramming, I take this to mean that they are sharing a system sector, and are not getting into the combat mode/window.