New patch??

lch · #1 July 18th, 2007, 06:10 PM

Quote:

Edi said:
I cannot give you the source files, but I can give you the strings extracted from the dump and accompanied by the fixed versions so you can look them over yourself.

That's exactly what I wanted. Having the original *.txt file and a patch (you know the *nix command "patch"?) would have been better maybe, but this is still very good. Please commit your final version when you have compiled it again.

lch · #2 July 18th, 2007, 06:27 PM

Edi, after a quick look it seems you really did extensive fixing. A few things that caught my eye:

- You sometimes use lower case for units, like "The asp turtle" at the very beginning, or "iron ancestor" for "Iron Ancestor" while at the same time you use "Tomb Oracles" and "Seal Guards" at the next occasion. How come?

- I think that it should be "appetite" instead of "appetites" in most cases, but then again I'm not a native English speaker. (see, I even have to capitalize that word...

)

Edi · #3 July 18th, 2007, 06:44 PM

Normal English capitalization rules. Everything is lower case unless the monster name is

Rank (e.g. Centurion, Legatus Legionis, Lord Guardian)
member of a military or other order (e.g. Wind Rider, Seal Guard, Guardian (of Ulm) as opposed to e.g. heavy infantry or infantry of Ulm)
unique monster (e.g. Eater of Gods, King of Banefires)
commander is not capitalized because that is too much of a generic descriptive rather than rank

As I said, everything will get reviewed when I work with the description files, but I did pay a lot of attention to this issue.

Spell descriptions (not in that text file) will have the names of all monsters they summon capitalized for clarity.

The selection of appetite/appetites depends on the context, but both of those are normal English. I'd elaborate, but I have early morning shift tomorrow and I need to hit the sack.

MaxWilson · #4 July 18th, 2007, 06:47 PM

Wow, I'm impressed. My eyes are bleeding from all that text. I didn't spot any issues with the corrected text, though. Nice work!

-Max

Beorne · #5 July 19th, 2007, 04:04 AM

Among all the bug everyone tries to push on the face of KO I'd like to highlight the (already highlighted) red bugs, in particular the fort issues (that should be very easy to correct) and the Dominion (spread, scales) issues, that can ruin a game. I kno these are JK things.
It's not fair that a game named Dominion has some big Dominion bugs.